Remove BigQuery delivery reconciliation + fix CI lint/format#5
Merged
Conversation
Mail is moving off the Gmail API onto an authenticated ESP (Mailjet) whose own event feed reports delivered/bounced/blocked directly, so reconciling against the Google Workspace Gmail log in BigQuery is no longer relevant. - Delete reconciliation.py and the reconcile_email_delivery Celery task - Drop the optional `reconciliation` extra (google-cloud-bigquery) - Generalize the send-idempotency guard comment (delivery_state='retried' is now ESP-agnostic) Retained (ESP-agnostic, to be repopulated from Mailjet events): the NotificationLog delivery columns (rfc2822_message_id, delivery_state, delivery_checked_at, delivery_detail), migration 0097, and Message-ID stamping -- so no DB migration change. Consuming app must drop the EMAIL_RECONCILIATION setting and the Celery beat entry for django_forms_workflows.reconcile_email_delivery. Version 0.76.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- tasks.py: sort the make_msgid import into the stdlib block (I001) - gmail_api.py, views.py: ruff format line wrapping Pure formatting; no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things
1. Remove BigQuery delivery reconciliation (0.76.0)
Mail is moving off the Gmail API onto an authenticated ESP (Mailjet), whose own event feed reports delivered/bounced/blocked. Reconciling against the Workspace Gmail log in BigQuery is no longer relevant.
reconciliation.py+ thereconcile_email_deliveryCelery taskreconciliationextra (google-cloud-bigquery)NotificationLogdelivery columns, migration 0097, Message-ID stamping — no DB migration changeEMAIL_RECONCILIATION+ the beat entry2. Fix the failing CI lint/format check
mainCI has been red since the prior reconciliation/genericize commits due to pre-existing ruff violations:tasks.py: sort themake_msgidimport into the stdlib block (I001)gmail_api.py,views.py: ruff format line wrappingBoth
ruff format --checkandruff checkpass locally now.🤖 Generated with Claude Code